prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.

https://react-redux-firebase.com

MIT License

2.55k stars 559 forks source link

fix(types): change updateProfile return type #983

Closed nkostiuchenko closed 4 years ago

nkostiuchenko commented 4 years ago

Description

updateProfile return void, but actual type is Promise (closes #975)

Check List

If not relevant to pull request, check off as complete

[x] All tests passing
[X] Docs updated with any changes or examples if applicable
[X] Added tests to ensure new feature(s) work properly

Relevant Issues

codecov[bot] commented 4 years ago

Codecov Report

Merging #983 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #983   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files          29       29           
  Lines         797      797           
=======================================
  Hits          704      704           
  Misses         93       93