prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.
https://react-redux-firebase.com
MIT License
2.55k stars 559 forks source link

feat(auth): github OAuth provider option in login #986

Closed davidepalazzo closed 4 years ago

davidepalazzo commented 4 years ago

Description

Hey there, this PR is for #971. I stumbled across this issue and since I'm working on a project that uses the Apple auth I thought it would have been worth it to add the other providers too.

The main addition in this PR is the provider type for the Credentials. I edited createAuthProvider to account for apple.com and yahoo.com and added it to supportedAuthProviders.

The unit test has been updated also to reflect the addition I made.

It's not a big one but hopefully it helps. Btw, I started using this package a couple of months ago and I'm loving it so far.

Let me know if there's anything that might need changing. Cheers.

Check List

If not relevant to pull request, check off as complete

Relevant Issues

971

codecov[bot] commented 4 years ago

Codecov Report

Merging #986 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #986      +/-   ##
==========================================
+ Coverage   88.33%   88.34%   +0.01%     
==========================================
  Files          29       29              
  Lines         797      798       +1     
==========================================
+ Hits          704      705       +1     
  Misses         93       93              
prescottprue commented 4 years ago

It definetly does help thanks! Really glad to hear that the package has been useful to you