feat(query): pass missing index error message to action dispatch (so logListenerError is not needed)

prescottprue / redux-firestore

Redux bindings for Firestore

MIT License

575 stars 102 forks source link

Open prescottprue opened 5 years ago

prescottprue commented 5 years ago

What is the feature?

Pass along the missing index error message into the action that is dispatched so that logListenerError is not needed to get the link that Firebase provides for setting the index (err.message instead of err)

What version would this apply to?

illuminist commented 5 years ago

I didn't provide logListenerError to rrf config in the repro. I think it's firebase itself logging out the error.

prescottprue commented 5 years ago

@illuminist It is from the error case of attaching the query, which redux-firestore uses internally so that it can dispatch an error action - so providing that config option makes sure to still log the error.

illuminist commented 5 years ago

I see it now. logListenerError is defaulted to true so that's why it logs an error without explicitly setting it.