search

preservim / nerdcommenter

Vim plugin for intensely nerdy commenting powers
Creative Commons Zero v1.0 Universal
4.97k stars 447 forks source link

Prevent caching of buffer commentstring #514

Closed ppwwyyxx closed 1 year ago

ppwwyyxx commented 1 year ago

Fix #477

alerque commented 1 year ago

Thanks for taking the time to contribute!

alerque commented 1 year ago

I had to revert this change. I think I understand what you were trying to fix but it completely blew up the plugin so it didn't work at all for my setup. I reverted it so people wouldn't run into the same total breakage. Can we look into what that was about?

ppwwyyxx commented 1 year ago

This works in my setup. How do I reproduce the breakage so I can look into it?

ppwwyyxx commented 1 year ago

I did notice one potential issue of infinite recursion. It's fixed here https://github.com/ppwwyyxx/nerdcommenter/commit/a3e82853089e0f7a14c3475ec997f1aa371f4210 but I'm not sure if that's the breakage you're seeing.

alerque commented 1 year ago

That commit you linked seems to fix the issue I was having with it. Can you submit that as a new PR?