search

preservim / tagbar

Vim plugin that displays tags in a window, ordered by scope
https://preservim.github.io/tagbar
Other
6.13k stars 487 forks source link

Add option to not trigger update on large files #656

Closed raven42 closed 4 years ago

raven42 commented 4 years ago

New feature for #636

Initial addition of large file support option. Just getting the ball rolling on this, but not fully implemented.

Looking to find a way to add output into tagbar window indicating that the file was ignored. Currently this will be displayed once in the vim messages history, but due to ordering of loading, the message isn't actually seen. I believe this is due to the messages history getting initialized after the plugins are loaded.

This adds an option g:tagbar_file_size_limit which can be set by the user to set a line count limit so the auto-update does not process anything on the file. This can be overridden by calling a new tagbar#ForceUpdate() routine

raven42 commented 4 years ago

Anybody have any idea how to display some info in the tagbar window for this?

alerque commented 4 years ago

Thanks for working on this @raven42.

Anybody have any idea how to display some info in the tagbar window for this?

Something would definitely make for a better UX than nothing.

This shouldn't be an error or anything else disruptive to a workflow, but something stuffed in the Tagbar buffer indicating that the file was deliberately not processed would both disambiguate intended from unintended function and give people a clue what to change to get a different result.

alerque commented 4 years ago

Just FYI @raven42 I didn't merge this yet because I wasn't sure if you were going to continue on poking at a status report of some kind. If you're not going to get around to that soon feel free to go ahead and merge when you think it's ready. As long as it has at least one current review approval from anybody else with write access you should me able to merge it yourself.

raven42 commented 4 years ago

@alerque: Thanks, ya I'm not quite ready to merge it in. Was going to try playing around with some way to display some message in the tagbar buffer first. If I can't really come up with anything, then I'll merge this in as is.

raven42 commented 4 years ago

Updated the code to use the fileinfo so we can track the file size and display a message in the tagbar window in the event the file size limit is exceeded.