search

preservim / tagbar

Vim plugin that displays tags in a window, ordered by scope
https://preservim.github.io/tagbar
Other
6.1k stars 485 forks source link

Tagbar window sets colorcolumn #783

Closed daedroza closed 2 years ago

daedroza commented 3 years ago

Currently the color column feature from vim when set in init.vimrc is also carried forward in the tagbar window. A screenshot is attached for reference that can be found here.

raven42 commented 2 years ago

@daedroza is the preferred behavior to always not have the color column? Is there any use case where someone would want to have this enabled?

daedroza commented 2 years ago

The original idea behind color column is to help programmers not exceed the line limit. Hence the feature is definitely needed in the primary working window. Since the tags are self-generated during runtime and the tagbar window cannot be modified in any way, there is no need to set the color column. Secondly, we assume that the terminal size is always greater than the color column size. That is not always true. In my opinion, it's best if we can disable the color column in tagbar window. We don't write anything in it, so why keep it? Added benefit of removing it is that it looks cleaner and more streamlined.

Please let me know about your opinion.

raven42 commented 2 years ago

I think this sounds reasonable. I'll leave this discussion open for a little bit and see if anybody else has any feelings about it before we default to disable it.