preservim / vim-markdown

Markdown Vim Mode
4.69k stars 524 forks source link

Add space in header regex #598

Open lggruspe opened 2 years ago

lggruspe commented 2 years ago

Fixes #597

Also adds some tests for HeaderDecrease and HeaderIncrease.

lggruspe commented 2 years ago

We could add an option to toggle this behavior. Maybe g:vim_markdown_hashtags or g:vim_markdown_space_in_atx_header will do?

What do you think, @tomtomjhj?

alerque commented 1 year ago

See comment in https://github.com/preservim/vim-markdown/pull/604#issuecomment-1263148391 that covers why we don't know whether this should be merged directly or not. The discussion about what Markdown flavor we are even targeting needs to be resolved first.

alerque commented 1 year ago

Also just for the record these two PRs are not duplicates, one addresses the syntax rules and one addresses the header level handling rules. Both should be merged, modified, or rejected in the same way.