search

preservim / vim-pencil

Rethinking Vim as a tool for writing
Other
1.57k stars 38 forks source link

Add highlight groups to blacklist in RST #86

Closed drippls closed 4 years ago

drippls commented 4 years ago

I have created a pull request.

Closes #84.

alerque commented 4 years ago

Thanks for taking the time to contribute @JudeLakkis. I do have some questions about this PR though, perhaps you could clarify a couple things and we can rebase the commit history to reflect the answers.

  1. I would plan on merging this with the squash option to get one single commit with a clear statement of what is being done here instead of 3 commits to make what is effectively a 1 line change to a single file. There isn't anything meaningful I'm missing that should be kept in history in separate commits right?

  2. Have you used this and verified that it actually works for you? I'm not an RST guy so I don't have files lying around to test on or really know what I'm looking for.