search

preservim / vim-textobj-quote

Use ‘curly’ quote characters in Vim
Other
123 stars 6 forks source link

Add CI job to run test suite #33

Closed alerque closed 2 years ago

alerque commented 2 years ago

See comments in #32

telemachus commented 2 years ago

I don't think I understand the "pending review" workflow at all.

Sorry to be dense, but do you want me to review this further? I can see that it needs one review to be merged, but I also see that you dismissed my earlier review. Let me know if you want another set of eyes on anything.

alerque commented 2 years ago

Sorry, the GitHub PR workflow works fine for some situations and less so for others. I've been trying to set it up to ease outside contributors getting their stuff looked at, but it's a bit noisy and even in the way for two active project contributors.

The fact that a review is requested is automatic just by opening a PR. Also the fact that I pushed an extra commit here dismissed your previous review and re-requested it automatically. I don't really think you need to dump effort into reviewing my addition of a CI badge to the readme ;-)

If it gets in the way dealing with outside contributions let me know and I'll fiddle with settings.

telemachus commented 2 years ago

I don't really think you need to dump effort into reviewing my addition of a CI badge to the readme ;-)

It was a great badge: I definitely approve. More seriously, thanks for clarifying re review requests.