preservim / vim-wordy

Uncover usage problems in your writing
Other
716 stars 23 forks source link

Feedback #1

Closed spf13 closed 10 years ago

spf13 commented 10 years ago

I love vim-wordy. I actually started writing my own, but came across yours and promptly threw mine away. Well done.

Here's some things I wish Wordy did better.

  1. The command names are kinda random, or at least they seem to be and I have a hard time remembering them. I wish that Wordy was the prefix instead of the postfix so I could just type :Wordy<tab> and see the list
  2. I wish there was a single dictionary or command that contained the most common or all of modes. I often run through a few of them correcting as I go, but I'd rather just do it in one sweep.

I'm happy to provide a pull request for either of these if you think they would be worthwhile.

reedes commented 10 years ago

Hey Steve, glad to hear you find Wordy useful.

Regarding command names, I had originally named them with a Wordy prefix, but I found myself annoyed at having to type so deeply to find a specific one. So I opted for unique names which would require only a few keystrokes, but I understand that memorization is required.

As a short term solution, aliases with Wordy as the prefix are fine by me. Send a pull request and I'll get it merged.

Regarding a single dictionary or command, there's an experimental CreativeWordy command that focuses on a subset of word lists relevant to creative writing. However, the down side is that it's not clear why a particular word or phrase is highlighted. Thus I haven't promoted its use or made other multi-list targets.

Perhaps the dictionaries could be available in a ring, where the dictionary name could appear in the status bar (or an echo) as the user uses a key-mapping to rapidly cycle among them?

mattly commented 10 years ago

@spf13 fwiw I had taken a stab at consolidating the wordy dictionaries into something that could be used to generate a quickfix list, highlighting all the various problem types in one pass with descriptions of why, but my naive algorithm turned out to be horrendously slow. In the process I learned that without the context of why something is highlighted, the highlighting is very unhelpful.

I think the quickfix list would be an ideal format for highlighting these sorts of problems, especially since it could provide a bit more context, but I think getting reasonable performance out of a processor will require a concerted effort.

reedes commented 10 years ago

Started implementing the ring idea on a new code branch.

It seems to work quite well, providing context as an echo. See Issue #2 for details.

reedes commented 10 years ago

Ring feature merged. Please give it a shot -- it could prove more useful than entering the commands directly.

ghost commented 10 years ago

Hi, I'm not sure if you're still interested in adding the Wordy prefixed aliases to the plugin but I've submitted a PR with the change I've been using. I still think I'll use the new ring feature most of the time but it's good to use Wordy<tab> to jog my memory for specific commands. I agree it's nice to have the unique names as well for running commands quickly.

Thank you for taking the time to make this plugin, it's great!

reedes commented 10 years ago

Completion feature for new Wordy {dictname} command added. Deprecated the DictNameWordy commands for the reasons stated above as well as because they pose a problem for localization plans.

Note that the WordyDictName approach would also be language-specific, so it has the same problem.

Closing.