search

preservim / vim-wordy

Uncover usage problems in your writing
Other
716 stars 23 forks source link

highlight wordy with SpellLocal or SpellRare #15

Closed sunaku closed 9 years ago

sunaku commented 9 years ago

Hello,

Currently, wordy words are highlighted with SpellBad, which is the same classification that the normal spellcheck feature uses most of the time. As a result, it's difficult to know which highlighted words come from spellcheck and which come from wordy. :confused: If wordy words were highlighted with SpellLocal or SpellRare instead, it would be easier to visually distinguish the two sources. :smiley_cat:

Thanks for your consideration.

reedes commented 9 years ago

I vaguely recall experimenting with using those alternative highlights, but didn't have much luck.

If you can get an alternative working properly, I'd be happy to accept a pull request.

sunaku commented 9 years ago

Patch attached, but it doesn't work as advertised in :help spell-wordlist-format :crying_cat_face:

sunaku commented 9 years ago

:book: I found the reason in :help spell-RARE and it's a matter of priority:

Rare words are highlighted differently from bad words. This is to be used for words that are correct for the language, but are hardly ever used and could be a typing mistake anyway. When the same word is found as good it won't be highlighted as rare.

There's an old Vim patch to fix this priority but it seems lost to history. :sob:

sunaku commented 9 years ago

Good news! NeoVim has been patched to make use of SpellRare in https://github.com/neovim/neovim/pull/2456, so I have updated the patch in this pull request to enable the SpellRare change only for NeoVim by creating a new /data-neovim subfolder and storing the modified dictionaries therein. :cake:

reedes commented 9 years ago

Thanks. I'll take a look at this later this week.

sunaku commented 9 years ago

:+1: Sounds good, and @jalvesaq and I have further refined the code in this pull request. :neckbeard: