preservim / vim-wordy

Uncover usage problems in your writing
Other
716 stars 23 forks source link

SpellRare #21

Closed Konfekt closed 8 years ago

Konfekt commented 8 years ago

Regarding the check:

      if has('nvim')
        " Dynamically convert SpellBad words into SpellRare words under NeoVim.
        " See issue 15 for details: https://github.com/reedes/vim-wordy/pull/15

Now Vim also has SpellRare so perhaps better than a check for nvim would be one for the highlight-group SpellRare? Don't know how though. Perhaps check for the exact patch of Vim that brought it in?

reedes commented 8 years ago

I'm checking for a patch/version in pencil for another feature, here: https://github.com/reedes/vim-pencil/blob/master/autoload/pencil.vim#L263-L270

If you can identify the ones associated with SpellRare, we can do something similar here.

Konfekt commented 8 years ago

Ok, I will grep for the SpellRare Patch. Apparently, ypu also know of no way to check for the existence of Highlight groups? Would be the cleaner solution.

Konfekt commented 8 years ago

Hello, I checked and SpellRare is there since 7.068. Thus, why check for nvim at all? Vim has it since ten years, too, it seems?

reedes commented 8 years ago

Now that you mention it, I vaguely recall trying to use the SpellRare highlight during development and never achieved the desired behavior. It had been fixed in neovim -- hence the patch from the other user.

I haven't tried recent versions of vim to see if SpellRare had been fixed.

So, if you (or someone else) wants to dig into this to see if SpellRare now works, and ideally at the patch it was fixed, we can switch over to that highlight group. (I won't have a chance to dig into it anytime soon, sorry.)

Konfekt commented 8 years ago

Yep, I just played around with the very latest Vim, and the issue persists. Highlight is fine with SpellBad, but SpellRare does not light up.

reedes commented 8 years ago

Thanks for testing that. Closing until Vim gets SpellRare highlighting working correctly.