search

preservim / vimux

easily interact with tmux from vim
MIT License
2.19k stars 159 forks source link

Added VimuxSetRunner to allow defining any panel as runner #171

Open viniciusgerevini opened 5 years ago

viniciusgerevini commented 5 years ago

Hi @benmills,

I think Vimux is pretty stable feature wise, however I was missing being able to define a specific pane as runner. I've made this change a few months ago and I've been using it in my fork since then.

The reasons why I think this feature is useful:

Feel free to decline this PR or suggest changes.

phelps-matthew commented 2 years ago

I tried integrating this function into my own init.vim and for reasons that behoove me I can't seem to get it to work with in the scenario of 3 panes. Screenshot from 2022-02-01 11-23-05

Despite applying let g:VimuxRunnerIndex = 2, the Vimux commands are always sent to panel 0 or panel 1 and never panel 2. In the scenario of two panels, it will correctly pipe output to appropriate panel.

I am using nested tmux sessions but I don't believe this to be the source of error. Any thoughts?

viniciusgerevini commented 2 years ago

Hey, sorry, I missed these updates. I don't use this plugin anymore and I won't have time to make the changes required. I'm currently using a custom one I created for my use-case. @phelps-matthew You can take a look at the code and see if you are able to fix your issue with it https://github.com/viniciusgerevini/tmux-runner.vim

alerque commented 2 years ago

Thanks for the backstorry @viniciusgerevini, and of course we understand. When things like this go unmaintained and stop accepting fixes they stop meeting needs.

That being said if you are anybody wants to work on either fixing up this PR or integrating any other "best of" features from the alternative I'd be happy to facilitate them getting integrated here now. I didn't go into detail on reviewing this PR because I wanted to make sure somebody was around to work on it still. I'd be willing to do that if somebody wants to see it brought on board.

phelps-matthew commented 2 years ago

Hey, sorry, I missed these updates. I don't use this plugin anymore and I won't have time to make the changes required. I'm currently using a custom one I created for my use-case. @phelps-matthew You can take a look at the code and see if you are able to fix your issue with it https://github.com/viniciusgerevini/tmux-runner.vim

This is delicious, thank you. Installed and is working great. Being able to set default behaviors like nearest pane to the right of active pane is exactly what I was looking for! :grinning: