preservim / vimux

easily interact with tmux from vim

MIT License

2.21k stars 161 forks source link

Hotfix for issue from PR #210 #215

Closed mvanderkamp closed 2 years ago

mvanderkamp commented 2 years ago

210 was missing some safety checks. See this comment. This PR adds guardrails to make sure that:

If VimuxUseNearest and VimuxRunnerQuery are both false/empty, we definitely don't try to re-use an existing pane/window.
If we do use a VimuxRunnerQuery, and that query happens to end up selecting the current pane (the one running vim), we won't use it.

mvanderkamp commented 2 years ago

I'm going to do a few more manual tests that everything is working correctly with this, so please don't merge this yet.

mvanderkamp commented 2 years ago

Okay, as far as I can tell everything is working correctly. I'm still not sure what exactly went wrong for newer tmux/neovim versions but it sounds like these guardrails do the trick.