presidentbeef / brakeman-site

Website for Brakeman
https://brakemanscanner.org
7 stars 18 forks source link

Redirect dangerous_eval to correct page #20

Closed BlakeWilliams closed 8 years ago

BlakeWilliams commented 8 years ago

This adds a redirect for:

http://brakemanscanner.org/docs/warning_types/dangerous_eval

to:

http://brakemanscanner.org/docs/warning_types/dangerous_evaluation/

This is necessary because the brakeman gem points to this url as the link for the dangerous eval rule.

BlakeWilliams commented 8 years ago

I also considered making /dangerous_eval the correct URL, but there was already one redirect pointing to /dangerous_evaluation so I made /dangerous_eval redirect instead. Let me know if we prefer it the other way around.

presidentbeef commented 8 years ago

It would be better the other way. As you can see, this isn't the first time I got the warning->URL mapping wrong.

BlakeWilliams commented 8 years ago

@presidentbeef Updated.

presidentbeef commented 8 years ago

Looks good, thanks!