search

presidentbeef / brakeman-site

Website for Brakeman
https://brakemanscanner.org
7 stars 18 forks source link

Japanese translation of Options documentation #29

Closed gazayas closed 6 years ago

gazayas commented 6 years ago

Hello,

Here is the Japanese translation of the options documentation, with help from @JunichiIto

Please let me know if this is the placement/file name/etc. that you want. Thanks,

Gabe

presidentbeef commented 6 years ago

Hi Gabriel,

Thank you for this! How do you think this should be linked up? Top of https://brakemanscanner.org/docs/options/ ? Bottom? Flag? "JP"? "JA"? :thinking:

Also, sorry for the timing, but can you update to match this change? https://github.com/presidentbeef/brakeman-site/commit/ec7f4bf6eddc59758500bcfcc3aa43c9b29f5e50

gazayas commented 6 years ago

Sure, I’ll update the change, I’ll try to get that in within the day Yeah, maybe at the bottom with the other links is best? JA could work, I was thinking 日本語 too for Japanese

presidentbeef commented 6 years ago

Merged and added the YAML front matter and link from /docs/options.

Can you add the link back to /docs like this? https://github.com/presidentbeef/brakeman-site/blame/master/source/docs/options/index.markdown#L274-L276

gazayas commented 6 years ago

Hello Justin, Thank you! I'll go ahead and open up a pull request concerning Junichi's comment above, as well as a link to the rest of the docs, and I think that should be it.