Closed gazayas closed 3 months ago
The pull request enhances the Brakeman application security scanner by adding a new command-line option to display ignored files and warnings, improving the reporting functionality, and enhancing the test suite to ensure the reliability and security-related functionality of the tool.
We ran 9 analyzers
against 7 files
and 1 analyzer
had findings. 8 analyzers
had no findings.
Analyzer | Findings |
---|---|
Authn/Authz Analyzer | 1 finding |
:green_circle: Risk threshold not exceeded.
Thanks!
Can you also add a simple test in test/tests/options.rb
?
Done!
Closes #1767.
After scaffolding a
Foo
model with a couple of vulnerabilities on a new application, runningbrakeman --show-ignored
displays the following:This ensures the exit code is unaffected by adding the flag (you can see in the test I added that the exit code returned is
3
which is the default in the command line test).I wanted to check the output and not just the exit code in the command line test, but I had some trouble finding the right way to do it.
Either way, Looking back at this comment, if we do want to affect the exit code or take another approach, I'd be glad to look over the logic again.