preslavmihaylov / booknotes

A collection of my book notes on various subjects, mainly computer science
MIT License
2.25k stars 496 forks source link

Make all images for clean architecture chapters smaller if too big #1

Closed preslavmihaylov closed 4 years ago

preslavmihaylov commented 4 years ago

There are instances of images which are too big because markdown stretches them by default.

Find all such instances and use regular HTML to limit the width of the pictures in order for them to look better.

palakdavda22 commented 4 years ago

Can you provide one file name in which the size of image is big, for better understanding?

preslavmihaylov commented 4 years ago

One type of problem is that often times, images appear on the same line as the previous row as in here: image

This can be fixed by putting a whitespace between the picture and the line before it.

Another problem is that often times, some images are rendered too big by default. example: image

I think this one can be reduced to be at most 300 pixels wide

Hassan-Elseoudy commented 4 years ago

I'm into it, May i be assigned this one @preslavmihaylov ?

preslavmihaylov commented 4 years ago

sure, you're good to go

preslavmihaylov commented 4 years ago

I will also accept pull requests for the same task but for the java concurrency in practice book

Hassan-Elseoudy commented 4 years ago

Waiting for review :) @preslavmihaylov

preslavmihaylov commented 4 years ago

Solved in #4