preslavmihaylov / todocheck

A static code analyser for annotated TODO comments
MIT License
422 stars 42 forks source link

Validation for existing github repository always fails if the repository is private #78

Open preslavmihaylov opened 3 years ago

preslavmihaylov commented 3 years ago

In #70, a new validation was added which first checks that a repository exists before proceeding with the rest of the application.

For private github repositories, this always fails because the apitoken is not acquired before making the validation. What's more, the API token is not added as an authorisation middleware when checking that the repository exists.

What to do about it:

preslavmihaylov commented 3 years ago

This issue also makes this warning: image

always visible as it checks for the existence of the token, without acquiring it first

preslavmihaylov commented 3 years ago

No need to create a new release after this is fixed as these changes are done after the latest release (#68)

preslavmihaylov commented 3 years ago

I've mitigated this incident, but I had to remove the #70 validation. In a follow-up PR, I will introduce it again.