pressbooks / ideas

Ideas for Pressbooks.
GNU General Public License v3.0
12 stars 4 forks source link

Make iFrames Responsive #77

Closed SteelWagstaff closed 3 years ago

SteelWagstaff commented 6 years ago

Feature Scope

Feature Description

I'd like to make iFrames embedded in Pressbooks size responsively. In particular, it would be nice to have videos and other elements inserted through oEmbed be resized as browser width changes. One possible model for implementation might be https://gist.github.com/jlengstorf/ce2470df87fd9a892f68.

Feature Use Case

This should benefit anyone who embeds interactive content in their site using oEmbeds. Currently, many oEmbed links include height and width values in their inline styling, which causes display problems, particularly on mobile devices. See the screenshots below for one example of a modestly-sized Youtube video on a narrow browser width:

screen shot 2018-04-26 at 11 59 53 am screen shot 2018-04-26 at 11 59 44 am
SteelWagstaff commented 4 years ago

Related: https://github.com/pressbooks/pressbooks-book/issues/592

SteelWagstaff commented 3 years ago

Closing in favor of https://github.com/pressbooks/pressbooks-book/issues/721