pressbooks / pressbooks-aldine

Aldine is the default root theme for Pressbooks.
https://pressbooks.org/
GNU General Public License v3.0
11 stars 7 forks source link

If a book is archived, spammed or deleted, it should be removed from the catalog #106

Closed colomet closed 6 years ago

colomet commented 6 years ago

Prerequisites

Description

maybe is about the same, but if a book is achive, we can still find the book in the catalog and also to open the book

achive or deactivate book. happen the same captura de pantalla 2018-03-07 a las 14 51 08

captura de pantalla 2018-03-07 a las 14 59 39

Steps to Reproduce

achive or deactivate a book

Expected behavior: no longer we see the books in the catalog. no longer the users can read the book.

Actual behavior: we can see the books in the catalog. and we can open the book and to read it.

book in the catalog captura de pantalla 2018-03-07 a las 14 50 59

archive book or deactivate book still available captura de pantalla 2018-03-07 a las 14 53 30

System Information

Pressbooks: [5.0.1] WordPress: [4.9.4] PHP: [7.0] System Information Root Blog Info

Root Blog ID: 1 Root Blog URL: http://pressbooks.lvps84-39-103-248.mammuts-servidor.es/ Browser

Platform: OS X Browser Name: Firefox Browser Version: 58.0 User Agent String: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0 WordPress Configuration

Network URL: http://pressbooks.lvps84-39-103-248.mammuts-servidor.es/ Network Type: Subdirectory Version: 4.9.4 Language: en_US WP_ENV: Not set WP_DEBUG: Enabled Memory Limit: 64M Pressbooks Configuration

Version: 5.0.1 Root Theme: Aldine Root Theme Version: 1.0.0-RC.2 Pressbooks Dependencies

Epubcheck: Not Installed Kindlegen: Installed xmllint: Installed PrinceXML: Not Installed Saxon-HE: Installed Must-Use Plugins

hm-autoloader.php: n/a Network Active Plugins

Pressbooks: 5.0.1 Wordfence Security: 7.1.0 Root Blog Active Plugins Inactive Plugins

mPDF for Pressbooks: 3.1.0 Textbooks for Pressbooks: 4.0.0 Server Configuration

PHP Version: 7.0.27 MySQL Version: 5.5.59 Webserver Info: Apache PHP Configuration

Safe Mode: Disabled Memory Limit: 256M Upload Max Size: 2M Post Max Size: 8M Upload Max Filesize: 2M Time Limit: 30 Max Input Vars: 1000 URL-aware fopen: On (1) Display Errors: On (1) PHP Extensions

OPcache: Zend XDebug: Disabled cURL: Supported cURL Version: 7.35.0 imagick: Installed xsl: Installed

greatislander commented 6 years ago

If you are logged in as a network admin, you will still be able to read the book (that's the way WordPress multisite works). If I mark a book as "Archived", log out, and visit the book, I see this:

screen shot 2018-03-07 at 10 15 20 am

Regarding your other point, we should remove books that have been archived from the catalog, so yes, that is a bug.

colomet commented 6 years ago

archived books yes. But

Deactivate reverses the activation step users go through when they signup for a site. It doesn’t permanently delete the site which can be reactivated at any time. Neither the front end nor the site admin screens are accessible .

so, if the book is deactivated, i do not have to be able to read it.

but i can : http://pressbooks.lvps84-39-103-248.mammuts-servidor.es/book-test/front-matter/introduction/

colomet commented 6 years ago

I see, Not admins but superadmins can.. ok. thanks