search

pressbooks / pressbooks-aldine

Aldine is the default root theme for Pressbooks.
https://pressbooks.org/
GNU General Public License v3.0
11 stars 7 forks source link

Increase size allocated for institutional logo #201

Open SteelWagstaff opened 4 years ago

SteelWagstaff commented 4 years ago

Currently supported logo size for webbook/network is 40 [height] x 265 [width]: https://github.com/pressbooks/pressbooks-aldine/blob/144da94e6fba9025ea82488afbe785a91132c416/inc/actions/namespace.php#L84-L91

The logo is displayed on with a max-height of 30px. Styling rules for these logos are defined in Aetna: https://github.com/pressbooks/aetna/blob/2ba47678d0b40666e53104c9824e07d250533cc4/assets/styles/layouts/_header.scss#L20-L38

Many institutions would like this to be larger (height wise, especially) and less banner-like (ratio of less than 6.5:1, for example).

jocelynpb2 commented 1 year ago

There has been interest in this issue here https://pressbooks.zendesk.com/agent/tickets/13038

MichSpieler commented 5 months ago

Another ticket where this has come up: https://pressbooks.zendesk.com/agent/tickets/20066

SteelWagstaff commented 5 months ago

We did some experimentation and testing. Max-height of 50px seems like the optimal improvement. We could also add an input/option to the customizer that allows the network manager to choose their desired logo height when uploading the logo, and to use 50px as default max-height fallback value.