pressbooks / pressbooks-aldine

Aldine is the default root theme for Pressbooks.
https://pressbooks.org/
GNU General Public License v3.0
11 stars 7 forks source link

Add classes for nav primary menu items and footer items #273

Closed richard015ar closed 3 years ago

richard015ar commented 3 years ago

Issue: https://github.com/pressbooks/pressbooks-book/issues/781

Related PR: https://github.com/pressbooks/pressbooks-book/pull/821

This change adds 2 new classes for each top menu items: Screenshot from 2021-07-27 10-46-03 and for footer menu items: Screenshot from 2021-07-27 10-46-30 with the objective to allow users to customize the style. Classes added: For top menu:

nav--primary-item (for top menu items customization)
nav--primary-item-home (home item)
nav--primary-item-contact (contact item)
nav--primary-item-my-books (My Books item)
nav--primary-item-sign-out (Sign Out item)
nav--primary-item-sign-in (Sign In Item)

For footer menu:

footer__pressbooks__links__list-item (for footer menu items)
footer__pressbooks__links__list-item-guide-tutorials (Guide and Tutorials item)
footer__pressbooks__links__list-item-contact (Contact item)

Test notes

codecov-commenter commented 3 years ago

Codecov Report

Merging #273 (9be5338) into dev (3f7cbb9) will not change coverage. The diff coverage is 0.00%.

:exclamation: Current head 9be5338 differs from pull request most recent head 43a0690. Consider uploading reports for the commit 43a0690 to get more accurate results Impacted file tree graph

@@          Coverage Diff          @@
##             dev    #273   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          8       8           
  Lines        767     796   +29     
=====================================
- Misses       767     796   +29     
Impacted Files Coverage Δ
inc/helpers/namespace.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f7cbb9...43a0690. Read the comment docs.