search

pressbooks / pressbooks-book-directory-fe

A Vue.js frontend for the Pressbooks Directory
0 stars 1 forks source link

Encoding issue in dev and staging environment #166

Closed richard015ar closed 3 years ago

richard015ar commented 3 years ago

After: https://github.com/pressbooks/pressbooks-book-directory-fe/issues/138 I added the a library to manage the meta tags within the directory. For that reason I removed the meta charset: https://github.com/pressbooks/pressbooks-book-directory-fe/pull/162/files#diff-c2cc24bc9001b11b6add48a4cd8f893d5d6c6e4d1bd254158bd14ab997f552cdL4 and added it to the App.vue component: https://github.com/pressbooks/pressbooks-book-directory-fe/pull/162/files#diff-7a7a37b12ee1265d7e27577ec286120d2cbc0940908635e264a2be44ccb9a8a0R81

This meta should be rendered at the beginning of the rendering process, since it allows to specify the character encoding to the DOM, instead add it dynamically. This problem causes an error in the encoding chars for Pagination component after build the code: Pressbooks-Directory-pagination

Add this meta tag to the index.html, instead dynamically in App.vue

richard015ar commented 3 years ago

Tested on dev and staging and it solved the issue. I think we could close this issue, after some test on yout side @SteelWagstaff if you are agree.