search

pressbooks / pressbooks-book-directory-fe

A Vue.js frontend for the Pressbooks Directory
0 stars 1 forks source link

Add 'read more' button to long descriptions to allow users to read full description #285

Closed SteelWagstaff closed 3 years ago

SteelWagstaff commented 3 years ago

We truncate book descriptions after 6 lines to make card height a bit more uniform. When description text has been truncated on a card, we should allow users to click a 'read more' option that expands the book card so that the full description becomes visible. See https://github.com/pressbooks/pressbooks-book-directory-fe/pull/83#issuecomment-672300096 for details and https://css-tricks.com/multiline-truncated-text-with-show-more-button/, https://www.npmjs.com/package/vue-read-more or https://medium.com/@sdkcodes/quick-vue-how-to-implement-read-more-feature-a116b1ba48a8 for some possible implementation methods.

SteelWagstaff commented 3 years ago

@richard015ar when testing locally and on v2.dev.pressbooks.directory, it appears that descriptions are being truncated after 4 lines rather than 6. We can leave this as is, but I was suprised to see it. Can you confirm that this is desired/intended behavior?