search

pressbooks / pressbooks-book

McLuhan is the default book theme for Pressbooks.
https://pressbooks.org
GNU General Public License v3.0
20 stars 16 forks source link

feat: display CTA banner when wp option is != 0 #1112

Closed richard015ar closed 1 year ago

richard015ar commented 1 year ago

Issue: https://github.com/pressbooks/pressbooks-network-analytics/issues/254

This PR allows to display the CTA banner when pressbooks_display_cta_banner wp option is '1'. If the option is not present, when by default it would be displayed anyway.

For testing see: https://github.com/pressbooks/pressbooks/pull/2953. The PR mentioned must be in place to test it properly.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1112 (2842745) into dev (08b33ce) will increase coverage by 0.11%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1112/graphs/tree.svg?width=650&height=150&src=pr&token=OGTBGoKr4m&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks)](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) ```diff @@ Coverage Diff @@ ## dev #1112 +/- ## ========================================== + Coverage 46.65% 46.77% +0.11% ========================================== Files 3 3 Lines 448 449 +1 ========================================== + Hits 209 210 +1 Misses 239 239 ``` | [Impacted Files](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) | Coverage Δ | | |---|---|---| | [inc/helpers/namespace.php](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks#diff-aW5jL2hlbHBlcnMvbmFtZXNwYWNlLnBocA==) | `48.12% <100.00%> (+0.17%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1112?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1112?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Last update [08b33ce...2842745](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1112?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks).