pressbooks / pressbooks-book

McLuhan is the default book theme for Pressbooks.
https://pressbooks.org
GNU General Public License v3.0
20 stars 16 forks source link

/h5p-listing/ not including the [h5p id="1"] #1114

Closed kqzheng closed 2 years ago

kqzheng commented 2 years ago

Prerequisites

Description

When adding"/h5p-listing/" at the end of the url to open the the H5P Activities List, the list doesn't include the H5P whose id="1". See these books for example:

Steps to Reproduce

  1. Open a book in Pressbooks that contains H5P
  2. Add /h5p-listing/ to the end of the books url to open the H5P Activities List

Expected behavior: The H5P Activities List shows all the H5P activities including the [h5p id="1"]

Actual behavior: The H5P Activities List starts with the [h5p id="2"] and not including the [h5p id="1"]

System Information

SteelWagstaff commented 2 years ago

Thanks for filing @kqzheng -- we'll look into this. Note for our dev team: the H5P page listing is generated here: https://github.com/pressbooks/pressbooks-book/blob/dev/page-h5p-listing.php

tw77 commented 2 years ago

This can be replicated on Integrations:

Screenshot 2022-10-12 at 6 33 27 AM

On a book with just one H5P activity, [h5p id="1"], no activities are listed.

SteelWagstaff commented 2 years ago

Appears to be working as expected on integrations. H5P activities with ID="1" are now appearing in h5p-listing page.

kqzheng commented 2 years ago

Thanks Steel! @tw77 I wonder if H5P id="1" is showing up in your book now? Unfortunately, they are still not appearing in my books.

SteelWagstaff commented 2 years ago

This has been fixed in development but not yet released or deployed to our production networks. It will be in our next release, @kqzheng

kqzheng commented 2 years ago

Oh sorry I didn't know that. Thanks again! @SteelWagstaff