search

pressbooks / pressbooks-book

McLuhan is the default book theme for Pressbooks.
https://pressbooks.org
GNU General Public License v3.0
20 stars 16 forks source link

fix: don't print h1 tag if chapter is numberless and has no title #1116

Closed greatislander closed 2 years ago

greatislander commented 2 years ago

Resolves pressbooks/pressbooks/issues/2582.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1116 (5900ac6) into dev (36ce86c) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1116/graphs/tree.svg?width=650&height=150&src=pr&token=OGTBGoKr4m&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks)](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) ```diff @@ Coverage Diff @@ ## dev #1116 +/- ## ======================================= Coverage 46.77% 46.77% ======================================= Files 3 3 Lines 449 449 ======================================= Hits 210 210 Misses 239 239 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1116?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1116?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Last update [36ce86c...5900ac6](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1116?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks).