search

pressbooks / pressbooks-book

McLuhan is the default book theme for Pressbooks.
https://pressbooks.org
GNU General Public License v3.0
20 stars 16 forks source link

chore: php 8 support #1118

Closed fdalcin closed 2 years ago

fdalcin commented 2 years ago

Part of pressbooks/private#961

This PR updates the code to support php 8

codecov[bot] commented 2 years ago

Codecov Report

Merging #1118 (7b2ed41) into dev (36ce86c) will decrease coverage by 0.07%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1118/graphs/tree.svg?width=650&height=150&src=pr&token=OGTBGoKr4m&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks)](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) ```diff @@ Coverage Diff @@ ## dev #1118 +/- ## ========================================== - Coverage 46.77% 46.69% -0.08% ========================================== Files 3 3 Lines 449 454 +5 ========================================== + Hits 210 212 +2 - Misses 239 242 +3 ``` | [Impacted Files](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) | Coverage Δ | | |---|---|---| | [inc/filters/namespace.php](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks#diff-aW5jL2ZpbHRlcnMvbmFtZXNwYWNlLnBocA==) | `27.77% <0.00%> (-0.80%)` | :arrow_down: | | [inc/actions/namespace.php](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks#diff-aW5jL2FjdGlvbnMvbmFtZXNwYWNlLnBocA==) | `48.38% <0.00%> (-0.38%)` | :arrow_down: | | [inc/helpers/namespace.php](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks#diff-aW5jL2hlbHBlcnMvbmFtZXNwYWNlLnBocA==) | `48.29% <0.00%> (+0.17%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1118?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1118?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Last update [36ce86c...7b2ed41](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1118?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks).