search

pressbooks / pressbooks-book

McLuhan is the default book theme for Pressbooks.
https://pressbooks.org
GNU General Public License v3.0
20 stars 16 forks source link

fix: H5P listing offset #1122

Closed fdalcin closed 1 year ago

fdalcin commented 1 year ago

Issue #1114

This PR aims to fix the H5P listing not showing the H5P with id 1.

How to test

Follow steps mentioned in the ticket, all H5P activities should be properly listed.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1122 (f1cdea9) into dev (09ddfa0) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1122/graphs/tree.svg?width=650&height=150&src=pr&token=OGTBGoKr4m&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks)](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) ```diff @@ Coverage Diff @@ ## dev #1122 +/- ## ========================================== - Coverage 46.77% 46.75% -0.02% ========================================== Files 3 3 Lines 449 447 -2 ========================================== - Hits 210 209 -1 + Misses 239 238 -1 ``` | [Impacted Files](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) | Coverage Δ | | |---|---|---| | [inc/helpers/namespace.php](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1122/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks#diff-aW5jL2hlbHBlcnMvbmFtZXNwYWNlLnBocA==) | `48.10% <100.00%> (-0.02%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1122?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1122?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Last update [09ddfa0...f1cdea9](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1122?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks).