search

pressbooks / pressbooks-book

McLuhan is the default book theme for Pressbooks.
https://pressbooks.org
GNU General Public License v3.0
20 stars 16 forks source link

fix: specify domain translation for contributors imploding method #1135

Closed richard015ar closed 1 year ago

richard015ar commented 1 year ago

Please, read https://github.com/pressbooks/pressbooks/pull/3043 for context.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1135 (427f975) into dev (d813974) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1135/graphs/tree.svg?width=650&height=150&src=pr&token=OGTBGoKr4m&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks)](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) ```diff @@ Coverage Diff @@ ## dev #1135 +/- ## ======================================= Coverage 46.68% 46.68% ======================================= Files 3 3 Lines 452 452 ======================================= Hits 211 211 Misses 241 241 ``` | [Impacted Files](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) | Coverage Δ | | |---|---|---| | [inc/helpers/namespace.php](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1135/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks#diff-aW5jL2hlbHBlcnMvbmFtZXNwYWNlLnBocA==) | `48.28% <100.00%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1135?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1135?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Last update [d813974...427f975](https://codecov.io/gh/pressbooks/pressbooks-book/pull/1135?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks).
richard015ar commented 1 year ago

We decided for a different approach.