pressbooks / pressbooks-book

McLuhan is the default book theme for Pressbooks.
https://pressbooks.org
GNU General Public License v3.0
20 stars 16 forks source link

fix: send export files event in google analytics v4 #1175

Closed richard015ar closed 1 year ago

richard015ar commented 1 year ago

Issue: https://github.com/pressbooks/pressbooks/issues/3412

Related PR: https://github.com/pressbooks/pressbooks/pull/3428

This PR sends download events using Google Analytics 4.

Testing case

codecov[bot] commented 1 year ago

Codecov Report

Merging #1175 (f68e738) into dev (d42497c) will not change coverage. The diff coverage is n/a.

:exclamation: Current head f68e738 differs from pull request most recent head 69c50c5. Consider uploading reports for the commit 69c50c5 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pressbooks/pressbooks-book/pull/1175/graphs/tree.svg?width=650&height=150&src=pr&token=OGTBGoKr4m&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks)](https://app.codecov.io/gh/pressbooks/pressbooks-book/pull/1175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) ```diff @@ Coverage Diff @@ ## dev #1175 +/- ## ======================================= Coverage 47.56% 47.56% ======================================= Files 3 3 Lines 574 574 ======================================= Hits 273 273 Misses 301 301 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pressbooks/pressbooks-book/pull/1175?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pressbooks/pressbooks-book/pull/1175?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Last update [d42497c...69c50c5](https://app.codecov.io/gh/pressbooks/pressbooks-book/pull/1175?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pressbooks).
richard015ar commented 1 year ago

@fdalcin I think it may impact clients, I will change it.