PDF: Media Fallback textbox images inherit an unwanted indent

pressbooks / pressbooks-book

McLuhan is the default book theme for Pressbooks.

https://pressbooks.org

GNU General Public License v3.0

20 stars 16 forks source link

PDF: Media Fallback textbox images inherit an unwanted indent #476

Closed dannylonglegs closed 3 years ago

dannylonglegs commented 5 years ago

Description

Media fallback textbox images inherit a text indent from regular textbox styles. This inherited style is not overwritten by the media fallback text indent style. This needs to be fixed.

mcgratay commented 4 years ago

Confirmed as reproducible. Tested in: McLuhan, Asimov, and Clarke.

Notes:

Does seem to affect both ebook and PDF formats.
Issue didn't appear in the Malala theme, but did appear in all other tested Buckram themes
Paragraph Separation setting must be set to Indent

Example: https://fallbacktextindent.textopress.com/

SteelWagstaff commented 3 years ago

Simplest fix is to add text-indent: 0 here: https://github.com/pressbooks/pressbooks-book/blob/49da8bea991394f158a1bc8462d97bdba8cd495b/packages/buckram/assets/styles/variables/_media.scss#L281

Could potentially be fixed by solution described in https://github.com/pressbooks/pressbooks-book/issues/355#issuecomment-812925481

SteelWagstaff commented 3 years ago

Tested and working as expected on integrations