search

pressbooks / pressbooks-book

McLuhan is the default book theme for Pressbooks.
https://pressbooks.org
GNU General Public License v3.0
20 stars 16 forks source link

Changing textbox colours under Theme Options cause SASS error #742

Closed pb-amy closed 3 years ago

pb-amy commented 3 years ago

Prerequisites

Description

This bug was issued through client interaction: https://pressbooks.zendesk.com/agent/tickets/4722

When textbox colours are changed on Theme Options and the changes are saved, it will issue a large SASS error message (copied and pasted below)

Subsequently, while the changes in the colour are reflected in the book preview/webbook, the textboxes stop showing on the editor itself. Screen recording of what happens: https://drive.google.com/file/d/11R-CGqXszEJP1sP-bAu4YmjRERjBoE9E/view

Two notes: There was no CSS and this is an issue across multiple themes (I tested Graham, McLuhan and Andreesen).

Here's the SASS error message:

There was a problem with SASS. Contact your site administrator. Error: @bottom-left is not a valid Selector in @bottom-left: failed at @bottom-left ScssPhp\ScssPhp\Compiler::evalSelectors on line 1, at column 0: /srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/_utilities.scss on line 10, at column 5 Call Stack: #0 mixin page-numbers /srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/_utilities.scss on line 106 #1 import /srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/structure/_running-content.scss /srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/styles/web/../components/_structure.scss on line 123 #2 import /srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/styles/web/../components/_structure.scss (unknown file) on line 17

Array
(
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/styles/web/_fonts.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/shared/uploads/sites/137/pressbooks/scss/_font-stack-web.scss] => 1616766923
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/book/typography/styles/_shapeshifter-font-stack-web.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/styles/components/_colors.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/variables/_colors.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/_colors.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/_utilities.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/styles/components/_elements.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/variables/_elements.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/_elements.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/elements/_blockquotes.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/elements/_body.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/elements/_headings.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/elements/_links.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/elements/_lists.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/elements/_miscellaneous.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/elements/_paragraphs.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/elements/_tables.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/styles/components/_specials.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/variables/_specials.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/_specials.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/specials/_columns.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/specials/_dropcaps.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/specials/_floats.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/specials/_footnotes.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/specials/_miscellaneous.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/specials/_pullquotes.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/specials/_separators.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/specials/_textboxes.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/specials/_glossaryterms.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/styles/components/_media.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/variables/_media.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/_media.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/media/_audio.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/media/_images.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/media/_interactive-content.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/media/_video.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/styles/components/_pages.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/variables/_pages.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/_pages.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/pages/_back-matter.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/pages/_chapters.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/pages/_front-matter.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/pages/_parts.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/pages/_titles.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/styles/components/_section-titles.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/variables/_section-titles.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/_section-titles.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/section-titles/_generic.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/section-titles/_back-matter.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/section-titles/_chapters.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/section-titles/_front-matter.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/section-titles/_parts.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/assets/styles/components/_structure.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/variables/_structure.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/structure/_general.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/structure/_recto-verso.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/structure/_numbering.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/structure/_content-strings.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/structure/_running-content.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/structure/_mixins.scss] => 1611118024
    [/srv/www/university.pressbooks.pub/releases/20210325005957/web/app/themes/pressbooks-book/packages/buckram/assets/styles/components/structure/_blank.scss] => 1611118024
)

Steps to Reproduce

  1. Change textbox colours under Theme Options (any textbox) and Save.
  2. Go on a chapter and insert that textbox.
  3. Preview the chapter.

Expected behavior: Textbox colours should save without an error message, and the textboxes should appear in the editor.

Actual behavior: Textbox colours show error message when saved, and textboxes do not show in the editor (but it does in the webbook)

System Information

SteelWagstaff commented 3 years ago

Issue was related to a third party dependency (https://github.com/scssphp/scssphp) which was updated to a version that introduced breaking changes in the pressbooksedu-golden-bedrock. We fixed by locking the dependency to a working version in pressbooks composer.json file: https://github.com/pressbooks/pressbooks/pull/2126/commits/a94b9c5fd39d484e50d15091182c81491d33eda3.