Deep linking bug in Moodle

pressbooks / pressbooks-lti-provider

A plugin which turns Pressbooks into an LTI provider.

GNU General Public License v3.0

7 stars 4 forks source link

Deep linking bug in Moodle #114

Closed SteelWagstaff closed 3 years ago

SteelWagstaff commented 3 years ago

When users attempt to create deep links in Moodle, they encounter a Invalid or missing lti_message_type parameter. error message. See https://youtu.be/oehV2OyuUQU

This error is triggered by Moodle under these conditions: https://github.com/moodle/moodle/blob/8c5162684144853a8ee3abd0862489e88421ab83/lib/ltiprovider/src/ToolProvider/ToolProvider.php#L680-L682

SteelWagstaff commented 3 years ago

It appears we broke this feature with this commit: https://github.com/pressbooks/pressbooks-lti-provider/blob/5fea8646f4cb5fc87c72fc7a0c82e40f30780ba2/inc/namespace.php#L45-L52

Using https://github.com/pressbooks/pressbooks-lti-provider/blame/a8f8403bd4fd15bdd5d1b02dffa84106cad9fe0b/inc/namespace.php#L45-L51 restores functionality.

SteelWagstaff commented 3 years ago

Deep linking works as expected on integrations: https://youtu.be/DQVPteR8Qao Book creation works as expected on integrations with the createbook endpoint as well. Nice work @richard015ar !