pressbooks / pressbooks-multi-institution

Tools for managing Pressbooks networks shared by multiple institutions
GNU General Public License v3.0
0 stars 1 forks source link

Institutional managers allowed box #174

Open JohnMcLeod13 opened 1 month ago

JohnMcLeod13 commented 1 month ago

I would expect that you can not enter an institutional manager name unless you check the box "Institutional Managers Allowed." Currently on the shared staging network, you can add the a user as the institutional manager without the allowed box checked.

greatislander commented 1 month ago

See also: https://github.com/pressbooks/pressbooks-multi-institution/issues/129#issuecomment-2027683916

Add/Edit Institution: The “Institution Managers Allowed” checkbox does not have any perceivable relationship to or impact on the “Institutional Managers” field. If it allows or disallows the use of the “Institutional Managers” field, the field should be hidden or shown as appropriate (or disabled or enabled as appropriate).

SteelWagstaff commented 1 month ago

I believe this was intentional -- the idea being that super admins (i.e. Pressbooks staff) could add institutional managers no matter what this setting was? Network managers should not be able to add institutional managers unless this box (or the buy-in box) are checked.

greatislander commented 1 month ago

I believe this was intentional -- the idea being that super admins (i.e. Pressbooks staff) could add institutional managers no matter what this setting was? Network managers should not be able to add institutional managers unless this box (or the buy-in box) are checked.

It needs a clearer label, then.