search

pressbooks / pressbooks-network-catalog

A Pressbooks plugin which provides an improved catalog for the Pressbooks Aldine theme
2 stars 1 forks source link

feat: use WordPress plugin dependency feature #358

Closed greatislander closed 5 months ago

greatislander commented 5 months ago

WordPress 6.5 (coming Tuesday) introduces plugin dependencies.

This means Pressbooks no longer needs to be a Composer requirement and we can remove the class_exists check.

What this looks like with WordPress 6.5 RC4:

WordPress 6.5 plugins screen showing Pressbooks and Pressbooks Network Catalog

Resolves https://github.com/pressbooks/local-dev-environment/issues/3.

private-packagist[bot] commented 5 months ago

composer.lock

Click to show 64 changes in this composer.lock file #### Dev Package changes | Package | Operation | From | To | About | |---------|-----------|------|----|-------| | aws/aws-crt-php | remove | v1.2.4 | - | - | | aws/aws-sdk-php | remove | 3.300.3 | - | - | | carbonphp/carbon-doctrine-types | remove | 3.2.0 | - | - | | composer/installers | remove | v2.2.0 | - | - | | davidgorges/human-name-parser | remove | 1.0.0 | - | - | | docraptor/docraptor | remove | 4.1.0 | - | - | | doctrine/inflector | remove | 2.0.10 | - | - | | fale/isbn | remove | 3.1.0 | - | - | | graham-campbell/result-type | remove | v1.1.2 | - | - | | gridonic/princexml-php | remove | 1.2.1 | - | - | | guzzlehttp/guzzle | remove | 7.8.1 | - | - | | guzzlehttp/promises | remove | 2.0.2 | - | - | | guzzlehttp/psr7 | remove | 2.6.2 | - | - | | illuminate/bus | remove | v8.83.27 | - | - | | illuminate/collections | remove | v8.83.27 | - | - | | illuminate/container | remove | v8.83.27 | - | - | | illuminate/contracts | remove | v8.83.27 | - | - | | illuminate/database | remove | v8.83.27 | - | - | | illuminate/events | remove | v8.83.27 | - | - | | illuminate/filesystem | remove | v8.83.27 | - | - | | illuminate/http | remove | v8.83.27 | - | - | | illuminate/macroable | remove | v8.83.27 | - | - | | illuminate/pagination | remove | v8.83.27 | - | - | | illuminate/pipeline | remove | v8.83.27 | - | - | | illuminate/session | remove | v8.83.27 | - | - | | illuminate/support | remove | v8.83.27 | - | - | | illuminate/view | remove | v8.83.27 | - | - | | intervention/image | remove | 2.7.2 | - | - | | jenssegers/imagehash | remove | v0.9.0 | - | - | | johnbillion/args | remove | 1.9.0 | - | - | | johnbillion/extended-cpts | remove | 5.0.6 | - | - | | laravel/helpers | remove | v1.7.0 | - | - | | masterminds/html5 | remove | 2.8.1 | - | - | | matomo/device-detector | remove | 6.3.0 | - | - | | maxbanton/cwh | remove | v2.0.4 | - | - | | monolog/monolog | remove | 2.9.2 | - | - | | mtdowling/jmespath.php | remove | 2.7.0 | - | - | | mustangostang/spyc | remove | 0.6.3 | - | - | | nesbot/carbon | remove | 2.72.3 | - | - | | phpcompatibility/php-compatibility | remove | 9.3.5 | - | - | | phpoption/phpoption | remove | 1.9.2 | - | - | | pressbooks/mix | remove | 2.1.3 | - | - | | pressbooks/pb-cli | remove | 3.1.0 | - | - | | **pressbooks/pressbooks** | remove | dev-dev d08b200 | - | - | | psr/clock | remove | 1.0.0 | - | - | | psr/http-client | remove | 1.0.3 | - | - | | psr/http-factory | remove | 1.0.2 | - | - | | psr/http-message | remove | 2.0 | - | - | | psr/simple-cache | remove | 1.0.1 | - | - | | ralouphie/getallheaders | remove | 3.0.3 | - | - | | scssphp/scssphp | remove | v1.12.1 | - | - | | squizlabs/php_codesniffer | remove | 3.9.0 | - | - | | symfony/error-handler | remove | v6.3.12 | - | - | | symfony/http-foundation | remove | v5.4.35 | - | - | | symfony/http-kernel | remove | v5.4.35 | - | - | | symfony/mime | remove | v5.4.35 | - | - | | symfony/polyfill-intl-idn | remove | v1.29.0 | - | - | | symfony/polyfill-php72 | remove | v1.29.0 | - | - | | symfony/translation | remove | v6.4.3 | - | - | | symfony/translation-contracts | remove | v3.4.1 | - | - | | symfony/var-dumper | remove | v6.4.3 | - | - | | vanilla/htmlawed | remove | v2.2.15 | - | - | | vlucas/phpdotenv | remove | v5.6.0 | - | - | | voku/portable-ascii | remove | 1.6.1 | - | - |

Settings · Docs · Powered by Private Packagist

private-packagist[bot] commented 5 months ago

The composer.lock diff comment has been updated to reflect new changes in this PR.

private-packagist[bot] commented 5 months ago

The composer.lock diff comment has been updated to reflect new changes in this PR.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.41%. Comparing base (4dad516) to head (635d917).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #358 +/- ## ========================================= Coverage 99.41% 99.41% Complexity 97 97 ========================================= Files 15 15 Lines 514 514 ========================================= Hits 511 511 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.