search

presscustomizr / customizr

Simple and fast WordPress theme designed to help you attract and engage more visitors. Provides a perfect user experience on smartphones. Powers 100k+ active sites around the world. Hundreds of 5-stars reviews received on WordPress.org.
https://presscustomizr.com/customizr
Other
137 stars 66 forks source link

Menus => disable by default the styling ( underline, background, ... ) of contextually active item #1718

Closed ghost closed 5 years ago

ghost commented 5 years ago

2019-03-23_10-43-16

Important when testing => make sure it is disabled for all contextually active candidates : ancestor, parent, etc

eri-trabiccolo commented 5 years ago

Should be 2-ms only.

ghost commented 5 years ago

@eri-trabiccolo I assign it to you. When you can. spec updated

eri-trabiccolo commented 5 years ago

Just one more thing. At the moment this option: Global Settings -> Formatting -> Animated underline effect on link hover

controls also the underlining for the current menu item. Meaning that, if that option is disabled, the current menu item "underline" is not present.

I would say that with the introduction of the new option the current menu item underline should not depend on the Global Settings -> Formatting -> Animated underline effect on link hover anymore

Agreed?!

ghost commented 5 years ago

yes agreed thanks.

eri-trabiccolo commented 5 years ago

(I pushed a first version, which is not a PR yet as I need to do some more tests)

eri-trabiccolo commented 5 years ago

Test ran fine on my side. The two options: Global Settings -> Formatting -> Animated underline effect on link hover and Header -> General design settings -> Highlight contextually active menu items

are totally decoupled.

ghost commented 5 years ago

also reported here : https://secure.helpscout.net/conversation/816950762/216807?folderId=607547