search

presscustomizr / customizr

Simple and fast WordPress theme designed to help you attract and engage more visitors. Provides a perfect user experience on smartphones. Powers 100k+ active sites around the world. Hundreds of 5-stars reviews received on WordPress.org.
https://presscustomizr.com/customizr
Other
137 stars 66 forks source link

mobile menu => javascript tap / click event possible issue #1733

Closed ghost closed 5 years ago

ghost commented 5 years ago

Mobile menu stops working with Draw Attention plugin

Here is the fix for another theme that was having similar issues. Basically, the JavaScript is listening for both a tap and click - unless the default is prevented, both actions fire on touch screens. https://wordpress.org/support/topic/mobile-menu-issues-on-pages-with-draw-attention/

Wordpress 5.1.1-en. CustomizrVersion: 4.1.37. Draw Attention Version 1.8.9 | By N Squared. Here is the site I am referencing, and the Draw Attention plugin is being used on the "Get Involved" menu page. http://pranichealingrichmond.com/

https://secure.helpscout.net/conversation/825871704/216938?folderId=610151

eri-trabiccolo commented 5 years ago

@Nikeo I went on the user's website on the "Get Involved" page and I cannot see any JS issue with the mobile menu. The issue there is that this "Draw Attention" content overlaps the mobile menu, because of a z-index "conflict". That's all. You might want to instruct the user to increase the header z-index, we have an option for that.

ghost commented 5 years ago

OK Thanks. Are you positive (test ) that increasing the z-index fixes the problem ?

eri-trabiccolo commented 5 years ago

Only on the user website, didn't test it locally :D a z-index of 401 seems to be fine