search

presscustomizr / customizr

Simple and fast WordPress theme designed to help you attract and engage more visitors. Provides a perfect user experience on smartphones. Powers 100k+ active sites around the world. Hundreds of 5-stars reviews received on WordPress.org.
https://presscustomizr.com/customizr
Other
137 stars 66 forks source link

User notice that body font size has changed since modular scale is deactivated by default #1755

Closed ghost closed 4 years ago

ghost commented 5 years ago

https://wordpress.org/support/topic/font-size-of-my-entire-website-suddenly-changed-2/

Todo => understand why we implemented the body font-size this way here : https://github.com/presscustomizr/customizr/blob/dev/core/class-fire-resources_fonts.php#L150 to discuss with @eri-trabiccolo during the next dev point

ghost commented 5 years ago

So, the problem impacts users who had customized the default font size ( 'tc_body_font_size' ) AND not deactivated the modular scale.

When modular scale is activated, Customizr applies a ratio of 0.833 for the body font size. Which was a bad choice no matter why we decided it. Because user does not really see the real chosen font-size.

Since latest version ( https://github.com/presscustomizr/customizr/commit/edb22089afe3f4110d9de06f349207f2c08a9190 ), the modular scale CSS has been deactivated by default. Which means that the 0.833 ratio is not applied by default anymore. For example, if the user picked body font-size was 18px, when modular scale was on, it was actually looking like 15px. But after the update, the font size was back to 18px.