search

presscustomizr / nimble-builder

Powerful yet very simple ( and free 😍 ) WordPress page builder using the native WordPress live customizer. Compatible with any WordPress theme. Used by 50k+ websites .
https://wordpress.org/plugins/nimble-builder/
Other
10 stars 3 forks source link

php warning when invoking sek_rgb2hsl() #303

Closed ghost closed 5 years ago

ghost commented 5 years ago

Reported here https://wordpress.org/support/topic/error-after-update-134/#post-11094587

I have problem with Customizr Theme and Nimble builder…

My site shows:

Warning: A non-numeric value encountered in /home/users/ttoo/public_html/karolalmert.com/wp-content/plugins/nimble-builder/inc/sektions/ccat-sektions.php on line 1948

in the code : https://github.com/presscustomizr/nimble-builder/blob/059a3b4e6c9ae08376254acf5fa7f80f9b941f19/inc/sektions/_front_dev_php/module_registration/10_0_0_sek_module_helpers_for_css_rules_generation.php#L540

This function is used for example when "lightening" the icon here : https://github.com/presscustomizr/nimble-builder/blob/master/inc/sektions/_front_dev_php/module_registration/front/4_1_3_sek_register_icon.php#L303

My guess is that the problem is related to the button or the icon that the user created on this page : https://karolalmert.com/ The automatic generation of the "color on hover" breaks. It might be because the icon or button color is not properly set, and that we don't have a strong enough check on the color input when generating the lighter hover color. @eri-trabiccolo can you try to reproduce and propose a fix for that when you can ?

ghost commented 5 years ago

@eri-trabiccolo I'm on it no worries !