presseddigital / colorit

A slick color picker fieldtype plugin for the Craft CMS control panel
Other
21 stars 8 forks source link

Function collision with another plugin #20

Open brimby opened 4 years ago

brimby commented 4 years ago

Both your plugin and craft-color-mixer by whoisjuan have a filter function called hexToRgb. In my installation your function gets priority when I use the filter. The problem is the two functions return different values, with yours printing "rgb(0,0,0)" and his printing just "0,0,0". So this created quite a bit of confusion and headaches when I was expecting to see the latter and didn't realize your plugin had its own set of filter functions. I submitted an issue with his plugin too, and I'm sure neither of you would want to change the name or return format for your functions, but something should be worked out in order to not confuse people who install both of your plugins like I did.