search

pressflow / 6

Each version of Pressflow is API-compatible with the same major Drupal version. For example, Pressflow 6 is compatible with all Drupal 6 modules. Pressflow 6 also integrates the SimpleTest system from Drupal 7 and the CDN support patch.
http://pressflow.org/
GNU General Public License v2.0
234 stars 88 forks source link

drupal_goto update changes between 6.3x and 6.38 #110

Open msusur opened 7 years ago

msusur commented 7 years ago

While upgrading to 6.38 I saw that the following line changed from extract(parse_url(urldecode($destination))); to extract(parse_url($destination));. Is there a good reason for that? Because it doesn't seem to be a backward compatible change. It breaks some of my urls such as; destination=page%253foo%253D10%2526bar%253D20.

I have created the pull request #109 in case that change make sense.

msusur commented 7 years ago

Would you mind dropping a comment on this one when you have time @pwolanin?

techmunk commented 7 years ago

From the Drupal 6.38 release notes at https://www.drupal.org/drupal-6.38-release-notes

The drupal_goto() function will no longer attempt to decode URLs passed to it via the "destination" query parameter in the URL. This could affect destination query parameters that were encoded using drupal_urlencode() before placing them on the page, but this should not be common since the drupal_urlencode() documentation already warned that using it in this manner could lead to unwanted double encoding.