search

pressflow / 6

Each version of Pressflow is API-compatible with the same major Drupal version. For example, Pressflow 6 is compatible with all Drupal 6 modules. Pressflow 6 also integrates the SimpleTest system from Drupal 7 and the CDN support patch.
http://pressflow.org/
GNU General Public License v2.0
235 stars 90 forks source link

Apply the changes from D6LTS 6.45 #122

Closed dsnopek closed 6 years ago

dsnopek commented 6 years ago

So, Drupal 6.45 was released to add PHP 7 support. Unfortunately, we haven't had a chance to really test PHP 7 with Pressflow 6. But here's the same changes applied to Pressflow, which at the very least shouldn't be harmful, and will help to keep the version numbers in sync.

pwolanin commented 6 years ago

This should maintain PHP 5 compatibility?

dsnopek commented 6 years ago

Yes, we've tested the D6LTS 6.45 release with PHP 5.2+

I think Pressflow only supports from PHP 5.3+, though, right?

pwolanin commented 6 years ago

@dsnopek the change set looks pretty reasonable to me and not very risky. You have not had problems with the LTS and this?

dsnopek commented 6 years ago

This is in use on customer sites for over a month now, and we haven't had any complaints. :-)

snpdev commented 6 years ago

Thanks @pwolanin and @dsnopek. Is a release 6.46 imminent?

FWIW, we run two Pressflow 6 sites on PHP 5.6.21 with no issues.

pwolanin commented 6 years ago

draft release: https://github.com/pressflow/6/releases/tag/untagged-3edf9f829738360c6972

Would be helpful if you can confirm master installs and/or updates cleanly for you.

On Wed, Nov 21, 2018 at 3:09 PM Mike Brooks notifications@github.com wrote:

Thanks @pwolanin https://github.com/pwolanin and @dsnopek https://github.com/dsnopek. Is a release 6.46 imminent?

FWIW, we run two Pressflow 6 sites on PHP 5.6.21 with no issues.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pressflow/6/pull/122#issuecomment-440794517, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGkqxsBjKd6NKZXGzQafLbXQrbWbz34ks5uxbL3gaJpZM4Xnwsm .

snpdev commented 6 years ago

@pwolanin, I have tested a site update from the latest master branch. No problems detected.