Menu rebuild lock_wait stampede

pressflow / 6

Each version of Pressflow is API-compatible with the same major Drupal version. For example, Pressflow 6 is compatible with all Drupal 6 modules. Pressflow 6 also integrates the SimpleTest system from Drupal 7 and the CDN support patch.

http://pressflow.org/

GNU General Public License v2.0

234 stars 89 forks source link

Menu rebuild lock_wait stampede #67

Open unn opened 11 years ago

unn commented 11 years ago

The lock_wait() in menu_rebuild() is harmful. During a menu_rebuild, we observed processes on web servers stuck for 30 seconds due to the lock_wait.

Since Pressflow is using a transaction, it seems unnecessary to wait the process until it has completed.

pwolanin commented 11 years ago

A couple whitespace changes in there should be omitted.

pwolanin commented 11 years ago

There are rare cases where the transaction will not be sufficient (e.g. the router or masks is empty), but I think those are rare enough to be worth trying this.