search

presslabs / zinc

Route 53 zone manager.
https://www.presslabs.com/code/zinc/
Other
42 stars 2 forks source link

Deleting a zone with an empty route53_id fails #139

Closed calind closed 7 years ago

calind commented 7 years ago

Deleting a zone with an empty route53 id should succeed. It should just delete the entity from DB.

rciorba commented 7 years ago

For reference the TB was:

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/rciorba/repos/zinc/dns/tasks.py", line 19, in aws_delete_zone
    aws_zone.delete()
  File "/home/rciorba/repos/zinc/dns/route53.py", line 134, in delete
    if self.exists:
  File "/home/rciorba/repos/zinc/dns/route53.py", line 109, in exists
    self._cache_aws_records()
  File "/home/rciorba/repos/zinc/dns/route53.py", line 120, in _cache_aws_records
    response = client.list_resource_record_sets(HostedZoneId=self.id)
  File "/home/rciorba/.venvs/zinc/lib/python3.5/site-packages/botocore/client.py", line 253, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/home/rciorba/.venvs/zinc/lib/python3.5/site-packages/botocore/client.py", line 517, in _make_api_call
    api_params, operation_model, context=request_context)
  File "/home/rciorba/.venvs/zinc/lib/python3.5/site-packages/botocore/client.py", line 569, in _convert_to_request_dict
    params=api_params, model=operation_model, context=context)
  File "/home/rciorba/.venvs/zinc/lib/python3.5/site-packages/botocore/hooks.py", line 227, in emit
    return self._emit(event_name, kwargs)
  File "/home/rciorba/.venvs/zinc/lib/python3.5/site-packages/botocore/hooks.py", line 210, in _emit
    response = handler(**kwargs)
  File "/home/rciorba/.venvs/zinc/lib/python3.5/site-packages/botocore/handlers.py", line 544, in fix_route53_ids
    params[name] = orig_value.split('/')[-1]
AttributeError: 'NoneType' object has no attribute 'split'