search

pressly / goose

A database migration tool. Supports SQL migrations and Go functions.
http://pressly.github.io/goose/
Other
6.58k stars 505 forks source link

Clickhouse allow_deprecated_syntax_for_merge_tree #535

Open mdsohelmia opened 1 year ago

mdsohelmia commented 1 year ago

Clickhouse Version 23.5.2.7

2023/06/13 11:13:24 migrate run: failed to ensure DB version: code: 36, message: This syntax for *MergeTree engine is deprecated. Use extended storage definition syntax with ORDER BY/PRIMARY KEY clause. See also allow_deprecated_syntax_for_merge_tree setting. exit status 1

mfridman commented 1 year ago

Relevant bit,

https://github.com/pressly/goose/blob/master/internal/dialect/dialectquery/clickhouse.go#L16-L17

although what does it mean for existing clickhouse instances that were created with the "old" query?

There's a few PR's from @iamluc @arunk-s related to clickhouse, so we should probably bump those and see if they also fix this issue:

https://github.com/pressly/goose/pull/520 https://github.com/pressly/goose/pull/530