search

pressly / goose

A database migration tool. Supports SQL migrations and Go functions.
http://pressly.github.io/goose/
Other
7.18k stars 523 forks source link

Add starrocks dialect #810

Closed barloc closed 2 months ago

barloc commented 3 months ago

This PR introduces a new Starrocks dialect (https://www.starrocks.io/). It uses mysql-go driver, but with new DDL for migrations table.

ashwin-weave commented 2 months ago

@mfridman Can we prioritise this? We have similar use case.

saiteja2021 commented 2 months ago

Thanks for adding StarRocks support..!! we are also waiting for this PR to be merged.

barloc commented 2 months ago

Hi. On new version 3.3.2 is issue with default current_timestamp https://github.com/StarRocks/starrocks/issues/50872 :(

mfridman commented 2 months ago

Hi. On new version 3.3.2 is issue with default current_timestamp StarRocks/starrocks#50872 :(

I presume this just means we have to pin to a specific version, and then upgrade whenever it's resolved. A bit surprised because I don't think we're using any fancy database features, goose is intentionally kept simple to support as many databases.

Either way, happy to merge this as I see there's a few requests. Thanks for the contribution.

mfridman commented 2 months ago

A few merge conflicts, but otherwise this should be good to go. Please merge master and run go mod tidy.