search

pressly / sup

Super simple deployment tool - think of it like 'make' for a network of servers
https://pressly.github.io/sup
MIT License
2.48k stars 178 forks source link

Upload issues #114

Closed slavaGanzin closed 6 years ago

slavaGanzin commented 7 years ago

Hello thanks for your awesome project.

I had an issues with upload:

  1. if src is not present I had no errors
  2. -debug key didn't change this behaviour
  3. there should be a message that something was(or not) copied
  4. currently I see only tar (not so usefull) messages: tar: .config/fish/fundle/edc/bass/.git: time stamp 2017-06-20 15:47:40 is 199.705320196 s in the future
  5. upload doesn't resolve local home dir using tilde ~ (As I found $HOME works, but...)
  6. Relative path issue 
    
upload:
  - src: ../.config/fish
    dst: /tmp

will copy into /tmp/.config/fish

but:

cp -r ../.config/fish /tmp

will copy contents into /tmp/fish which is default behavior for unix


*****
```sh
sup -v                                                                  
# 0.5
uname -a
# Linux war 4.11.5-1-ARCH #1 SMP PREEMPT Wed Jun 14 16:19:27 CEST 2017 x86_64 GNU/Linux
go version
# go1.8.3 linux/amd64

Thanks

VojtechVitek commented 7 years ago

Hi, thanks for reporting this issues.

However, I won't really have time to debug and fix the cause in the near future. Any help or Pull Request would be greatly appreciated.

slavaGanzin commented 7 years ago

(As I found $HOME works, but...)

no it's not :(

I'm far from golang. But I'll document this in readme

slavaGanzin commented 7 years ago

Before I was using:

local:
   scp -r from $SUP_HOST:to

for this task and the only problem I had I can $SUP_HOST == 'localhost' in local section. So I just hardcoded host I think this was perfect solution and upload is ambiguous and unneeded :)

RussellLuo commented 7 years ago

There was also an absolute path issue, but the pull request submitted to address this issue got no response :-(

VojtechVitek commented 7 years ago

Sorry, I've been very busy recently with other work and I can't focus on pressly/sup at this point.

My plan was to upgrade the whole upload thing with rsync and provide much better error messages.

VojtechVitek commented 7 years ago

113 has been merged, thanks @RussellLuo for the reminder!

VojtechVitek commented 6 years ago

This has been resolved in #113. Please reopen if I'm missing something.