search

prestaconcept / PrestaSitemapBundle

A symfony bundle that provides tools to build a rich application sitemap. The main goals are : simple, no databases, various namespace (eg. google image), respect constraints etc.
MIT License
355 stars 102 forks source link

Auto adding alternales #205

Closed fabianoroberto closed 4 years ago

fabianoroberto commented 5 years ago

Handle auto adding alternales by adding defaults.default_locale and default.locales parameters

Also added .idea in .gitignore file to prevent commit unuseful files of Jetbrains IDE.

Any dubts/suggestions about PR are welcome

yann-eugone commented 5 years ago

Thank you for this idea. We will need more explanation about what you coded, because there is a lot, and i'm not sure to understand every part.

Can you please add some explanation comments, and write some tests to cover your changes ?

fabianoroberto commented 4 years ago

I added a simple test to check alternate section. If you merge before #224 I can add other integration tests

yann-eugone commented 4 years ago

Hi @fabianoroberto ! Since the test suite refactoring has been merged, do you still want to work on this ? Or do you want someone to continue your work ?

fabianoroberto commented 4 years ago

Hi @yann-eugone, at this moment I'm a little busy so I cannot follow this task. I'd be very happy if someone can continue this MR

yann-eugone commented 4 years ago

Replaced with #251